RFR: 8371783: Refactor GCCause in VM_CollectForMetadataAllocation
Kim Barrett
kbarrett at openjdk.org
Tue Nov 18 06:47:09 UTC 2025
On Thu, 13 Nov 2025 10:08:36 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:
> Hello,
>
> We should improve how we use and set GCCause in VM_CollectForMetadataAllocation to make it more clear when reading the code what is going on.
>
> When constructing a VM_CollectForMetadataAllocation operation, we pass in a GCCause, which is not always the cause that is used, since we might also have to clear soft references as a last resort if earlier collection attemps is not enough to free up memory.
>
> The GCCauseSetter at the start of this operation is also redundant as subsequent calls to initiate a GC set the cause themselves.
>
> Testing:
> * Oracle's tier1-3
Looks good.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28287#pullrequestreview-3475764571
More information about the hotspot-gc-dev
mailing list