RFR: 8037914: Add JFR event for string deduplication [v7]
Francesco Andreuzzi
fandreuzzi at openjdk.org
Tue Nov 18 09:23:38 UTC 2025
On Mon, 17 Nov 2025 14:27:24 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
>> Francesco Andreuzzi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
>>
>> - remove elapsed. remove idle
>> - Merge branch 'master' into JDK-8037914
>> - rename. start/end time
>> - no start
>> - enable
>> - bytes to size
>> - disable
>> - revert
>> - one event
>> - trailing
>> - ... and 5 more: https://git.openjdk.org/jdk/compare/c7ce9f21...fc47a64e
>
> From a JFR perspective, this looks good. Ideally, the values of the event should be sanity-checked, but I understand this might be tricky to do in a reliable manner. Hunting down false positives would just be a waste of time. The copyright year of the test should be 2025.
>
> It would be good if someone on the GC team could take a look at the GC-related code.
Thanks for the review @egahlin and @albertnetymk.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28015#issuecomment-3546398933
More information about the hotspot-gc-dev
mailing list