RFR: 8371667: Shenandoah: Re-design alloc request type enum for better efficiency and cleaner code [v13]
Xiaolong Peng
xpeng at openjdk.org
Tue Nov 18 10:13:41 UTC 2025
On Mon, 17 Nov 2025 22:54:45 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision:
>>
>> tidy up
>
> src/hotspot/share/gc/shenandoah/shenandoahAllocRequest.hpp line 204:
>
>> 202: }
>> 203:
>> 204: bool is_old() const {
>
> Should all of these be inline? (Looks to me like the implementations are no larger than the code required to call and process result.)
Yes, they are all inline methods, even w/o the explicit `inline`, CLion simply tells me the keyword `inline` is redundant in the header file if the method is entirely declared in header file.
Just be better readability, I added `inline` for all these methods.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28247#discussion_r2537289651
More information about the hotspot-gc-dev
mailing list