RFR: 8371990: Remove two second delayed OOME after GC shutdown [v3]
Stefan Karlsson
stefank at openjdk.org
Wed Nov 19 07:21:58 UTC 2025
On Tue, 18 Nov 2025 20:48:42 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add comment to block_if_java_thread
>
> src/hotspot/share/gc/shared/gcVMOperations.cpp line 132:
>
>> 130: if (_is_shutting_down) {
>> 131: // Block forever if a Java thread is triggering a GC after
>> 132: // the GC have started to shut down.
>
> s/have/has/
Fixed. Thanks.
> src/hotspot/share/gc/shared/gcVMOperations.hpp line 143:
>
>> 141:
>> 142: // This function returns the value of CollectedHeap::is_shutting_down() that
>> 143: // was recorded in the prologue. Unlike, CollectedHeap::is_shutting_down(),
>
> Remove comma after "Unlike".
Fixed. Thanks.
> src/hotspot/share/gc/shared/gcVMOperations.hpp line 146:
>
>> 144: // this function can be called without acquiring the Heap_lock.
>> 145: //
>> 146: // This funciton exists so that code that tries to schedule a GC operation
>
> s/funciton/function/
Fixed. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28349#discussion_r2540827549
PR Review Comment: https://git.openjdk.org/jdk/pull/28349#discussion_r2540827393
PR Review Comment: https://git.openjdk.org/jdk/pull/28349#discussion_r2540827732
More information about the hotspot-gc-dev
mailing list