RFR: 8372610: G1: JDK-8297692 broke code roots scan measurements
Thomas Schatzl
tschatzl at openjdk.org
Wed Nov 26 16:43:25 UTC 2025
Hi all,
please review this change that fixes "Code Root Scan" logging - a wrong scope for the timing measurements made these values always print `0.00` and the duration moved to the "Other time" category.
E.g. without patch:
[1.121s][debug][gc,phases] GC(7) Code Root Scan (ms): Min: 0.00, Avg: 0.00, Max: 0.00, Diff: 0.00, Sum: 0.00, Workers: 4
[1.485s][debug][gc,phases] GC(8) Code Root Scan (ms): Min: 0.00, Avg: 0.00, Max: 0.00, Diff: 0.00, Sum: 0.00, Workers: 8
[1.715s][debug][gc,phases] GC(9) Code Root Scan (ms): Min: 0.00, Avg: 0.00, Max: 0.00, Diff: 0.00, Sum: 0.00, Workers: 8
with patch:
[1.392s][debug][gc,phases] GC(7) Code Root Scan (ms): Min: 0.00, Avg: 0.03, Max: 0.12, Diff: 0.12, Sum: 0.21, Workers: 8
[1.638s][debug][gc,phases] GC(8) Code Root Scan (ms): Min: 0.00, Avg: 0.03, Max: 0.15, Diff: 0.15, Sum: 0.26, Workers: 8
[1.862s][debug][gc,phases] GC(9) Code Root Scan (ms): Min: 0.00, Avg: 0.03, Max: 0.16, Diff: 0.15, Sum: 0.26, Workers: 8
Testing: gha, local checking
Thanks,
Thomas
-------------
Commit messages:
- 8372610
Changes: https://git.openjdk.org/jdk/pull/28513/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28513&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8372610
Stats: 14 lines in 1 file changed: 6 ins; 4 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/28513.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28513/head:pull/28513
PR: https://git.openjdk.org/jdk/pull/28513
More information about the hotspot-gc-dev
mailing list