RFR: 8319540: GC: Make TestSelectDefaultGC use createTestJavaProcessBuilder
Stefan Karlsson
stefank at openjdk.org
Thu Nov 27 08:57:04 UTC 2025
On Wed, 26 Nov 2025 16:03:23 GMT, Ramkumar Sunderbabu <rsunderbabu at openjdk.org> wrote:
> > We now how this:
> > ```
> > // Start VM without specifying GC
> > OutputAnalyzer output = GCArguments.executeTestJava(
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > It sounds to me that the comment say that we're running with out specifying a GC, but with this change we do. I think you need to update the comment or add appropriate requires line(s).
>
> We still don't allow the GC flags. If the test was started with a GC flags, "@requires vm.gc.Serial & vm.gc.G1" will skip the test. Hence, the comment is still valid.
OK. Now I understand.
I saw that you mentioned the obscure `@requires vm.gc.Serial & vm.gc.G1` pattern and that you were going see if we could make a clearer property. I think that would be beneficial.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28422#issuecomment-3584796289
More information about the hotspot-gc-dev
mailing list