RFR: 8372610: G1: JDK-8297692 broke code roots scan measurements [v2]

[Ivan Walulya]

On Thu, 27 Nov 2025 16:27:28 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this change that fixes "Code Root Scan" logging - a wrong scope for the timing measurements made these values always print `0.00` and the duration moved to the "Other time" category.
>> 
>> E.g. without patch:
>> 
>> 
>> [1.121s][debug][gc,phases] GC(7)     Code Root Scan (ms):           Min: 0.00, Avg: 0.00, Max: 0.00, Diff: 0.00, Sum: 0.00, Workers: 4
>> [1.485s][debug][gc,phases] GC(8)     Code Root Scan (ms):           Min: 0.00, Avg: 0.00, Max: 0.00, Diff: 0.00, Sum: 0.00, Workers: 8
>> [1.715s][debug][gc,phases] GC(9)     Code Root Scan (ms):           Min: 0.00, Avg: 0.00, Max: 0.00, Diff: 0.00, Sum: 0.00, Workers: 8
>> 
>> 
>> with patch:
>> 
>> 
>> [1.392s][debug][gc,phases] GC(7)     Code Root Scan (ms):           Min: 0.00, Avg: 0.03, Max: 0.12, Diff: 0.12, Sum: 0.21, Workers: 8
>> [1.638s][debug][gc,phases] GC(8)     Code Root Scan (ms):           Min: 0.00, Avg: 0.03, Max: 0.15, Diff: 0.15, Sum: 0.26, Workers: 8
>> [1.862s][debug][gc,phases] GC(9)     Code Root Scan (ms):           Min: 0.00, Avg: 0.03, Max: 0.16, Diff: 0.15, Sum: 0.26, Workers: 8
>> 
>> 
>> Testing: gha, local checking
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   * reformatting

Marked as reviewed by iwalulya (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/28513#pullrequestreview-3516855683