RFR: 8346005: Parallel: Incorrect page size calculation with UseLargePages [v5]

[Joel Sikström]

On Mon, 15 Sep 2025 13:26:24 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Refactor the heap-space and OS memory interface code to clearly separate two related but distinct concepts: `alignment` and `os-page-size`. These are now represented as two fields in `PSVirtualSpace`.
>> 
>> The parallel heap consists of four spaces: old, eden, from, and to. The first belongs to the old generation, while the latter three belong to the young generation.
>> 
>> The size of any space is always aligned to `alignment`, which also determines the unit for resizing. To keep the implementation simple while allowing flexible per-space commit and uncommit operations, each space must contain at least one OS page. As a result, `alignment` is always greater than or equal to `os-page-size`.
>> 
>> When using explicit large pages -- which require pre-allocating large pages before the VM starts -- the actual OS page size is not known until the heap has been reserved. The additional logic in `ParallelScavengeHeap::initialize` detects the OS page size in use and adjusts `alignment` if necessary.
>> 
>> Test: tier1–8
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'master' into pgc-largepage
>  - page-size
>  - Merge branch 'master' into pgc-largepage
>  - Merge branch 'master' into pgc-largepage
>  - Merge branch 'master' into pgc-largepage
>  - pgc-largepage

src/hotspot/share/gc/parallel/psVirtualspace.hpp line 44:

> 42:   const size_t _alignment;
> 43: 
> 44:   // OS page size used. If using transparent large pages, it's the desired large page-size.

I'd change this to say Transparent Huge Pages instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26700#discussion_r2367988953