RFR: 8353115: GenShen: mixed evacuation candidate regions need accurate live_data [v9]
Kelvin Nilsen
kdnilsen at openjdk.org
Thu Oct 2 23:09:50 UTC 2025
On Tue, 16 Sep 2025 23:15:11 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix compilation errors after merge
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahOldHeuristics.cpp line 91:
>
>> 89: }
>> 90:
>> 91: // Between consecutive mixed-evacuation cycles, the live data within each candidate region may change due to
>
> I think we could reduce some duplication and call `recalibrate_old_collection_candidates_live_memory` here if the function didn't have the side effect of updating `_live_bytes_in_unprocessed_candidates`. Perhaps the function could return `total_live_data` and be `const`?
Good suggestion. I've refactored a little. I think it can't be const because we sort the _region_data.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24319#discussion_r2400354971
More information about the hotspot-gc-dev
mailing list