RFR: 8367413: Refactor types in Arguments::set_heap_size() [v4]
Joel Sikström
jsikstro at openjdk.org
Tue Oct 7 09:34:21 UTC 2025
On Tue, 7 Oct 2025 09:19:03 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Joel Sikström has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Revert MaxRAM default removals, defer to future enhancement
>
> src/hotspot/share/runtime/arguments.cpp line 1544:
>
>> 1542: uint64_t max_memory = (uint64_t)(((double)physical_memory * MaxRAMPercentage) / 100);
>> 1543:
>> 1544: const size_t reasonable_min = limit_by_size_t_max(min_memory);
>
> I wonder whether we should emit a log-info/warning, if `limit_by_size_t_max` does change the result.
I'm a bit hesitant to add non-debug logging here as I don't have resources to test this on a 32-bit VM. Also, I'm not sure how much extra code we'd like to have for 32-bit support.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27224#discussion_r2410006373
More information about the hotspot-gc-dev
mailing list