RFR: 8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet [v12]
Kelvin Nilsen
kdnilsen at openjdk.org
Tue Oct 7 16:42:14 UTC 2025
On Thu, 2 Oct 2025 23:12:01 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with five additional commits since the last revision:
>>
>> - small refactoring
>> - OO refinements to used_regions_size()
>> - fix broken assert from previous commit
>> - OO refinements to free_unaffiliated_regions()
>> - OO refinements to max_capacity()
>
> src/hotspot/share/gc/shenandoah/shenandoahGeneration.cpp line 953:
>
>> 951: }
>> 952:
>> 953: size_t ShenandoahGeneration::max_capacity() const {
>
> We never instantiate `ShenandoahGeneration` even non-generational mode gets `ShenandoahGlobalGeneration`. You could make these methods pure virtual. The implementation here should never be called.
Thanks. Making this change also.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26867#discussion_r2411236294
More information about the hotspot-gc-dev
mailing list