RFR: 8314599: [GenShen] Couple adaptive tenuring and generation size budgeting [v3]
William Kemper
wkemper at openjdk.org
Tue Oct 7 21:18:06 UTC 2025
On Mon, 6 Oct 2025 22:35:22 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix windows build more
>
> src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.inline.hpp line 62:
>
>> 60:
>> 61: size_t ShenandoahCollectionSet::get_live_bytes_in_young_regions() const {
>> 62: return _young_bytes_to_evacuate - _young_bytes_to_promote;
>
> I'm wondering if these new names properly reflect the intention. It seems get_live_byte_in_young_regions() really means get_live_bytes_that_we_intend_to_evacuate_to_young(). (This number does not include _live_bytes_in_young_regions() that we expect to evacuate to old.)
I called the complementary method `get_live_bytes_in_tenurable_regions`. How about `get_live_bytes_in_untenurable_regions`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27632#discussion_r2411948730
More information about the hotspot-gc-dev
mailing list