RFR: 8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet [v12]
Kelvin Nilsen
kdnilsen at openjdk.org
Tue Oct 7 22:00:26 UTC 2025
On Thu, 2 Oct 2025 23:55:42 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with five additional commits since the last revision:
>>
>> - small refactoring
>> - OO refinements to used_regions_size()
>> - fix broken assert from previous commit
>> - OO refinements to free_unaffiliated_regions()
>> - OO refinements to max_capacity()
>
> src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp line 498:
>
>> 496:
>> 497: class ShenandoahVerifyHeapRegionClosure : public ShenandoahHeapRegionClosure {
>> 498: private:
>
> Formatting the access modifiers like this looks idiosyncratic:
>
> % grep -ri -P '^ private:' src/hotspot | wc -l
> 115
> % grep -ri -P '^private:' src/hotspot | wc -l
> 1444
I've fixed this here, and in neighboring declarations of same file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26867#discussion_r2412018805
More information about the hotspot-gc-dev
mailing list