RFR: 8369809: G1: Merge G1CollectedHeap::do_collection_pause_at_safepoint[_helper] [v2]

[Thomas Schatzl]

On Tue, 14 Oct 2025 10:56:58 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this trivial fix to merge `G1CollectedHeap::do_collection_pause_helper` with `do_collection_pause`. The helper method is only called there in this single place and does not add anything but two asserts.
>> 
>> Testing: gha, local compilation
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/hotspot/share/gc/g1/g1CollectedHeap.cpp
>   
>   * ayang review

src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 2630:

> 2628: void G1CollectedHeap::do_collection_pause_at_safepoint(size_t allocation_word_size) {
> 2629:   assert_at_safepoint_on_vm_thread();
> 2630:   guarantee(!is_stw_gc_active(), "collection is not reentrant");

Suggestion:

  assert(!is_stw_gc_active(), "collection is not reentrant");

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27790#discussion_r2428730025