RFR: 8212084: G1: Implement UseGCOverheadLimit
Francesco Andreuzzi
fandreuzzi at openjdk.org
Thu Oct 23 10:08:06 UTC 2025
On Thu, 23 Oct 2025 07:11:16 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review these changes to implement the `UseGCOverheadLimit` functionality for G1 (and make the implementation for Parallel GC have similar output).
>
> The `UseGCOverheadLimit` feature prematurely returns `null` from a GC if GC cpu usage limits and heap usage limits are met for some time. This is to avoid a VM limping along if garbage collection gets into an endless cycle of garbage collections or until a "real" OOME is thrown.
>
> What is important here is how this works (derived from the Parallel GC implementation):
>
> * check overheads at the end of the (initial) garbage collection (before upgrading) to see whether we are over the limits for a successive amount of GCs.
> * keep doing GCs without actually allocating memory for the allocation request to keep on measuring gc CPU usage. This is important for measuring the correct cpu usage in case of the application being able to free memory on the OOME.
>
> Testing: tier1-5 without any OOMEs due to this feature, test case
>
> Thanks,
> Thomas
test/hotspot/jtreg/gc/TestUseGCOverheadLimit.java line 82:
> 80: System.out.println(output.getStdout());
> 81:
> 82: Asserts.assertTrue(output.getStdout().indexOf("GC Overhead Limit exceeded too often (5).") != -1,
Why not `OutputAnalyzer#stdoutShouldContain` here?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27950#discussion_r2454595619
More information about the hotspot-gc-dev
mailing list