RFR: 8370732: vmTestbase/nsk/jvmti/AttachOnDemand/attach020/TestDescription.java intermittent fails [v5]
SendaoYan
syan at openjdk.org
Wed Oct 29 06:42:08 UTC 2025
On Wed, 29 Oct 2025 04:05:31 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update the test description
>
> test/hotspot/jtreg/vmTestbase/gc/gctests/SoftReference/soft003/soft003.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2007, 2025, Oracle and/or its affiliates. All rights reserved.
>
> Only copyright changes in this file.
Sorry. Fixed.
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach020/TestDescription.java line 57:
>
>> 55: * -jdk ${test.jdk}
>> 56: * -target nsk.jvmti.AttachOnDemand.attach020.attach020Target
>> 57: * -javaOpts="-XX:+UsePerfData -Xmx128M ${test.vm.opts} ${test.java.opts} -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI"
>
> Please remove Xmx128M in all tests, it is not needed now.
Thanks, all the '-Xmx128M' has been removed.
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach021/TestDescription.java line 53:
>
>> 51: * -jdk ${test.jdk}
>> 52: * -target nsk.jvmti.AttachOnDemand.attach021.attach021Target
>> 53: * -javaOpts="-XX:+UsePerfData -Xmx128M ${test.vm.opts} ${test.java.opts} -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI"
>
> Please remove Xmx128M, it is not needed now.
Thanks, all the '-Xmx128M' has been removed.
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/GarbageCollectionStart/gcstart001.java line 68:
>
>> 66: private int runThis(String argv[], PrintStream out) {
>> 67: try {
>> 68: for (int i=0; i<ITERATIONS; i++)
>
> The loop and try//catch are not needed anymore.
Thanks. The loop and try/catch has been removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28011#discussion_r2471882988
PR Review Comment: https://git.openjdk.org/jdk/pull/28011#discussion_r2471881837
PR Review Comment: https://git.openjdk.org/jdk/pull/28011#discussion_r2471882285
PR Review Comment: https://git.openjdk.org/jdk/pull/28011#discussion_r2471886100
More information about the hotspot-gc-dev
mailing list