RFR: 8370804: G1: Make G1HeapRegionAttr::remset_is_tracked() conform to coding style [v2]

Thomas Schatzl tschatzl at openjdk.org
Wed Oct 29 10:14:29 UTC 2025


On Wed, 29 Oct 2025 10:11:00 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please fix several places where the `remset_is_tracked` getter and related identifiers do not fit hotspot style, recommending the verb as first part.
>> 
>> Testing: gha
>> 
>> (Please note the dependency on #28038)
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/hotspot/share/gc/g1/g1CollectedHeap.cpp

Fine with me.

src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 2556:

> 2554:     virtual bool do_heap_region(G1HeapRegion* r) {
> 2555:       G1CollectedHeap* g1h = G1CollectedHeap::heap();
> 2556:       bool const is_remset_tracked = g1h->region_attr(r->bottom()).is_remset_tracked();

Suggestion:

      const bool is_remset_tracked = g1h->region_attr(r->bottom()).is_remset_tracked();

-------------

PR Review: https://git.openjdk.org/jdk/pull/28039#pullrequestreview-3392539395
PR Review Comment: https://git.openjdk.org/jdk/pull/28039#discussion_r2472403934


More information about the hotspot-gc-dev mailing list