RFR: 8370807: G1: Improve region attribute table method naming

Thomas Schatzl tschatzl at openjdk.org
Wed Oct 29 11:00:38 UTC 2025


On Wed, 29 Oct 2025 10:29:04 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this cleanup of the region attribute registration methods.
>> 
>> Testing: gha
>> 
>> Thanks,
>>   Thomas
>
> src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp line 207:
> 
>> 205: }
>> 206: 
>> 207: void G1CollectedHeap::register_old_collection_set_region_with_region_attr(G1HeapRegion* r) {
> 
> Why "collection_set" in the name? Is it a precondition that `r` is in cset?

It must be a region that is currently being added to the collection set. I.e. registered to the attribute table to be in the collection set.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28038#discussion_r2472548602


More information about the hotspot-gc-dev mailing list