RFR: 8370804: G1: Make G1HeapRegionAttr::remset_is_tracked() conform to coding style [v3]

Ivan Walulya iwalulya at openjdk.org
Thu Oct 30 08:48:28 UTC 2025


On Thu, 30 Oct 2025 08:15:14 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please fix several places where the `remset_is_tracked` getter and related identifiers do not fit hotspot style, recommending the verb as first part.
>> 
>> Testing: gha
>> 
>> (Please note the dependency on #28038)
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
> 
>  - Merge branch 'master' into 8370804-remset-is-tracked-style2
>  - Merge branch '8370807-pinned-region-flag-not-propagated' into 8370804-remset-is-tracked-style2
>  - Merge branch 'master' into 8370807-pinned-region-flag-not-propagated
>  - * ayang review
>  - Update src/hotspot/share/gc/g1/g1CollectedHeap.cpp
>  - 8370804
>    
>    Hi all,
>    
>      please fix several places where the `remset_is_tracked` getter and related identifiers do not fit hotspot style, recommending the verb as first part.
>    
>    Testing: gha
>    
>    Thanks,
>      Thomas
>  - 8370807
>    
>    Hi all,
>    
>      please review this cleanup of the region attribute registration methods.
>    
>    Testing: gha
>    
>    Thanks,
>      Thomas

Still good!

-------------

Marked as reviewed by iwalulya (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28039#pullrequestreview-3398069512


More information about the hotspot-gc-dev mailing list