RFR: 8369913: Parallel: Refactor PSAdjustTask

Joel Sikström jsikstro at openjdk.org
Fri Oct 31 12:06:03 UTC 2025


On Wed, 15 Oct 2025 13:31:06 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Cleanup roots processing (adjusting/remapping) during the adjust-phase of full-gc, so that relevant roots are grouped together with some documentations. Also, the use of `SubTasksDone` is replaced with a `volatile bool`, which is more transparent in the context.
> 
> Test: tier1-5

Looks good.

src/hotspot/share/gc/parallel/psParallelCompact.cpp line 1383:

> 1381:     _weak_proc_task(nworkers),
> 1382:     _nworkers(nworkers),
> 1383:     _code_cache_claimed(false) {

Looks weird that we're not calling the constructor for `_oop_storage_iter`, but it's fine since it only has a default-ctor anyway. Up to you if we add it.

-------------

Marked as reviewed by jsikstro (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27822#pullrequestreview-3403915379
PR Review Comment: https://git.openjdk.org/jdk/pull/27822#discussion_r2481163210


More information about the hotspot-gc-dev mailing list