RFR: 8366462: Test gc/z/TestCommitFailure.java#Normal failed: expected output missing
Erik Österlund
eosterlund at openjdk.org
Mon Sep 1 07:50:52 UTC 2025
On Sun, 31 Aug 2025 10:26:28 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
> The newly introduced test is intermittently failing where it tries to verify that we got a commit failure. I suggest we simply remove this verification as an initial fix.
>
> Trying to reproduce these failure paths reliably with a blackbox test is probably not possible. So we would have to extend the JVM with whitebox hooks for doing exactly what we want. I think we need to be very careful in such a design to not affect the maintainability and readability to the code.
>
> For now it is enough that this test intermittently exercises the commit failure paths and intermittently would reproduce any regressions.
>
> The risk is having to be more diligent in the future with checking that this test still works when changing ZPageAllocator policies or implementation details.
Looks good.
-------------
Marked as reviewed by eosterlund (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27023#pullrequestreview-3172488696
More information about the hotspot-gc-dev
mailing list