RFR: 8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java
jonghoonpark
duke at openjdk.org
Tue Sep 2 21:06:59 UTC 2025
On Wed, 13 Aug 2025 19:11:25 GMT, jonghoonpark <duke at openjdk.org> wrote:
> This change updates `TestReclaimStringsLeaksMemory.java` to properly guard against unsupported GC arguments.
> Previously, the test only checked `@requires vm.gc == "null"`.
>
> The fix separates the tests and adds explicit `@requires` clauses for each GC configuration to ensure the test only runs when supported.
>
> This prevents test failures on VMs that do not support the specified GC.
>
> (This is my first contribution to the JDK. Thank you for your review and guidance.)
<img width="847" height="627" alt="image" src="https://github.com/user-attachments/assets/55657b4a-6c56-4798-ad17-caeafc619019" />
I previously signed the OCA and have already contributed to Graal.
However, the GitHub Actions checks are not passing.
Is there anything else I need to do?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26766#issuecomment-3185242360
More information about the hotspot-gc-dev
mailing list