RFR: 8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java [v2]

[jonghoonpark]

On Wed, 3 Sep 2025 07:09:36 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> jonghoonpark has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Merge branch 'master' of https://git.openjdk.org/jdk into JDK-8364927-add-requires-annotation
>>  - 8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java
>>    
>>    Signed-off-by: jonghoonpark <dev at jonghoonpark.com>
>
> test/hotspot/jtreg/gc/stress/TestReclaimStringsLeaksMemory.java line 38:
> 
>> 36: 
>> 37: /*
>> 38:  * @test TestReclaimStringsLeaksMemorySerial
> 
> In other tests we set the id instead. For example, in the TestSystemGC we have:
> 
>  * @test id=Serial
> 
> 
> Maybe do the same for this test?

Thank you for your feedback.

Then, would modifying the code as shown below be acceptable?


/*
 * @test TestReclaimStringsLeaksMemory
 * ...
 * @run driver/timeout=480 gc.stress.TestReclaimStringsLeaksMemory
 */

/*
 * @test id=Serial
 * ...
 * @run driver/timeout=480 gc.stress.TestReclaimStringsLeaksMemory -XX:+UseSerialGC
 */

/*
 * @test id=Parallel
 * ...
 * @run driver/timeout=480 gc.stress.TestReclaimStringsLeaksMemory -XX:+UseParallelGC
 */

/*
 * @test id=G1
 * ...
 * @run driver/timeout=480 gc.stress.TestReclaimStringsLeaksMemory -XX:+UseG1GC
 */

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26766#discussion_r2318120781