RFR: 8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java [v2]

Stefan Karlsson stefank at openjdk.org
Wed Sep 3 11:51:42 UTC 2025


On Wed, 3 Sep 2025 11:26:23 GMT, jonghoonpark <duke at openjdk.org> wrote:

>I thought it was there to test the case where a GC other than SerialGC, ParallelGC, or G1GC might be used as the default.

That could be the case. However, I think that most of our tests don't care about that and instead follow the pattern in TestSystemGC.java

> Then, would it be better to remove the first test and add tests for other GCs later only if they turn out to be necessary?

I think so.

Do you know if ZGC and Shenandoah works with this test? If they do you could also consider adding them. Though that requires you to verify that they actually do pass the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26766#discussion_r2318715650


More information about the hotspot-gc-dev mailing list