RFR: 8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java [v3]
Albert Mingkun Yang
ayang at openjdk.org
Wed Sep 3 16:49:46 UTC 2025
On Wed, 3 Sep 2025 13:35:40 GMT, jonghoonpark <duke at openjdk.org> wrote:
>> This change updates `TestReclaimStringsLeaksMemory.java` to properly guard against unsupported GC arguments.
>> Previously, the test only checked `@requires vm.gc == "null"`.
>>
>> The fix separates the tests and adds explicit `@requires` clauses for each GC configuration to ensure the test only runs when supported.
>>
>> This prevents test failures on VMs that do not support the specified GC.
>>
>> (This is my first contribution to the JDK. Thank you for your review and guidance.)
>
> jonghoonpark has updated the pull request incrementally with one additional commit since the last revision:
>
> remove non-specific GC test item and include ZGC and Shenandoah
>
> Signed-off-by: jonghoonpark <dev at jonghoonpark.com>
Marked as reviewed by ayang (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/26766#pullrequestreview-3181474447
More information about the hotspot-gc-dev
mailing list