RFR: 8366881: Parallel: Obsolete HeapMaximumCompactionInterval [v2]

[Francesco Andreuzzi]

On Fri, 5 Sep 2025 09:30:45 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Remove a produce flag that controls maximum-compaction during a full-gc. The existing criteria, such as heap usage, old-gen density, are enough for deciding maximum-compaction.
>> 
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - review
>  - Merge branch 'master' into pgc-max-compaction-obsolete
>  - pgc-max-compaction-obsolete

src/hotspot/share/gc/parallel/psParallelCompact.cpp line 829:

> 827: }
> 828: 
> 829: bool PSParallelCompact::check_maximum_compaction(bool should_do_max_compaction,

I'd expect this method not to have any side effect, does it?

If that's the case, you could consider not having `should_do_max_compaction` as a parameter, and replace calls to  `check_maximum_compaction` with `should_do_max_compaction || check_maximum_compaction(...)`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27091#discussion_r2330487908