RFR: 8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java [v4]
Stefan Karlsson
stefank at openjdk.org
Tue Sep 9 11:01:06 UTC 2025
On Mon, 8 Sep 2025 22:52:19 GMT, jonghoonpark <duke at openjdk.org> wrote:
>> This change updates `TestReclaimStringsLeaksMemory.java` to properly guard against unsupported GC arguments.
>> Previously, the test only checked `@requires vm.gc == "null"`.
>>
>> The fix separates the tests and adds explicit `@requires` clauses for each GC configuration to ensure the test only runs when supported.
>>
>> This prevents test failures on VMs that do not support the specified GC.
>>
>> (This is my first contribution to the JDK. Thank you for your review and guidance.)
>
> jonghoonpark has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>
> - Merge branch 'openjdk:master' into JDK-8364927-add-requires-annotation
> - remove non-specific GC test item and include ZGC and Shenandoah
>
> Signed-off-by: jonghoonpark <dev at jonghoonpark.com>
> - Merge branch 'master' of https://git.openjdk.org/jdk into JDK-8364927-add-requires-annotation
> - 8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java
>
> Signed-off-by: jonghoonpark <dev at jonghoonpark.com>
Marked as reviewed by stefank (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/26766#pullrequestreview-3200904713
More information about the hotspot-gc-dev
mailing list