RFR: 8367240: Parallel: Refactor PSScavengeCLDClosure [v3]

[Stefan Karlsson]

On Tue, 9 Sep 2025 15:28:12 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Refactor `PSScavengeCLDClosure` and its "enclosing" `PSScavengeFromCLDClosure` so that all CLD logic is encapsulated in the CLD closure, without polluting the oop closure.
>> 
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - review
>  - Merge branch 'master' into pgc-cld
>  - review
>  - pgc-cld

Thanks for fixing the style. I've added two small nits, but otherwise I've approved the PR.

src/hotspot/share/gc/parallel/psClosure.inline.hpp line 80:

> 78: typedef PSRootsClosure</*promote_immediately=*/true> PSPromoteRootsClosure;
> 79: 
> 80: 

Suggestion:

src/hotspot/share/gc/parallel/psClosure.inline.hpp line 111:

> 109: // Scavenges the oop in a ClassLoaderData.
> 110: class PSScavengeCLDClosure: public CLDClosure {
> 111:   PSPromotionManager* _pm;

To make the two classes consistent w.r.t. newlines.
Suggestion:

  PSPromotionManager* _pm;

-------------

Marked as reviewed by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27165#pullrequestreview-3202203055
PR Review Comment: https://git.openjdk.org/jdk/pull/27165#discussion_r2334042227
PR Review Comment: https://git.openjdk.org/jdk/pull/27165#discussion_r2334050782