RFR: 8367240: Parallel: Refactor PSScavengeCLDClosure [v4]
Albert Mingkun Yang
ayang at openjdk.org
Wed Sep 10 10:24:27 UTC 2025
On Wed, 10 Sep 2025 09:45:41 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:
>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review
>
> src/hotspot/share/gc/parallel/psClosure.inline.hpp line 101:
>
>> 99: RawAccess<IS_NOT_NULL>::oop_store(p, new_obj);
>> 100:
>> 101: if (PSScavenge::is_obj_in_young(new_obj) && !_has_oops_into_young_gen) {
>
> Why do you need to check `!_has_oops_into_young_gen` ?
It's to avoid writing `_has_oops_into_young_gen` multiple times, if it's already `true`. (Both versions are correct though.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27165#discussion_r2336289581
More information about the hotspot-gc-dev
mailing list