RFR: 8367347: Serial: Refactor CLDScanClosure [v4]

Thomas Schatzl tschatzl at openjdk.org
Thu Sep 11 07:39:29 UTC 2025


On Wed, 10 Sep 2025 19:38:14 GMT, Francesco Andreuzzi <fandreuzzi at openjdk.org> wrote:

>> Refactor `CLDScanClosure` so that all CLD logic is encapsulated in the CLD closure, without polluting the oop closure.
>> 
>> Test: tier1-2, running tier3
>
> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   inline

Changes requested by tschatzl (Reviewer).

src/hotspot/share/gc/serial/defNewGeneration.cpp line 98:

> 96:   class CLDOopClosure : public OffHeapScanClosure {
> 97:     DefNewGeneration* _g;
> 98: 

Suggestion:



`_g` is never referenced anywhere in `CLDOopClosure`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/27199#pullrequestreview-3209470365
PR Review Comment: https://git.openjdk.org/jdk/pull/27199#discussion_r2339136155


More information about the hotspot-gc-dev mailing list