RFR: 8367401: Parallel: Remove unused field in PSKeepAliveClosure
Albert Mingkun Yang
ayang at openjdk.org
Thu Sep 11 09:26:46 UTC 2025
On Thu, 11 Sep 2025 09:13:56 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> Looks good. I wouldn't mind if you also removed the:
>
> ```
> assert(_promotion_manager != nullptr, "Sanity");
> ```
It's to ensure the passed-in arg is not null. There is only one caller, which does provide a valid arg, but for catching misuse more promptly, I'd keep it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27210#issuecomment-3279447585
More information about the hotspot-gc-dev
mailing list