RFR: 8367401: Parallel: Remove unused field in PSKeepAliveClosure
Stefan Karlsson
stefank at openjdk.org
Thu Sep 11 13:08:16 UTC 2025
On Thu, 11 Sep 2025 08:50:51 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Trivial removing dead code.
>
> Test: tier1
I'm still convinced that you would find this programming error immediately in your local testing, even before you send of a patch for CI testing. Then you could see in your debugger that the filed was null.
I think we're holding on to this assert because it was added some time ago, not because it is important to have. I don't think we would have added it if the code was written today. Case in-point, take a look at the rewrite you did in the latest PR:
https://github.com/openjdk/jdk/pull/27165
There's no null check of the `_pm` fields there.
Anyways, we can keep the check, I just think that it has marginal value here.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27210#issuecomment-3280556610
More information about the hotspot-gc-dev
mailing list