RFR: 8366865: G1: Allocation GC Pauses Triggered after JVM has started shutdown [v2]

Thomas Schatzl tschatzl at openjdk.org
Mon Sep 15 13:19:50 UTC 2025


On Wed, 10 Sep 2025 13:55:44 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> src/hotspot/share/gc/shared/gcVMOperations.cpp line 115:
>> 
>>> 113: 
>>> 114:   // Check invocations
>>> 115:   if (skip_operation() || Universe::heap()->is_shutting_down()) {
>> 
>> Can the new condition be inlined inside `skip_operation()`?
>
> In the first iteration I had it inlined, but then decided to make it more explicit. I can change it back if you prefer

No particular preference, but the comments in `skip_operation()` need to be adjusted to also indicate that as additional condition.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27190#discussion_r2348946011


More information about the hotspot-gc-dev mailing list