RFR: 8367759: G1: Move G1UpdateRegionLivenessAndSelectForRebuildTask into its own file

Thomas Schatzl tschatzl at openjdk.org
Wed Sep 17 09:57:37 UTC 2025


On Tue, 16 Sep 2025 14:19:41 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this change to move `G1UpdateRegionLivenessAndSelectForRebuildTask` into a separate file. I would like to merge this class and G1BuildCandidateRegionsTask in the near future because the latter mostly repeats the work of the former anyway, but together (with helper classes) they are quite large (if not large already by themselves). This should help make `g1ConcurrentMark.cpp` a little more manageable.
> 
> There is no change in the code, just moving and fixing includes/adding forwards.
> 
> Testing: local compilation, gha
> 
> Thanks,
>   Thomas

src/hotspot/share/gc/g1/g1ConcurrentMark.hpp line 96:

> 94: // Closure used by CM during concurrent reference discovery
> 95: // and reference processing (during remarking) to determine
> 96: // if a particular object is alive. It is primarilfy used

Suggestion:

// if a particular object is alive. It is primarily used

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27314#discussion_r2354928534


More information about the hotspot-gc-dev mailing list