RFR: 8367450: Shenandoah: Log the composition of the collection set [v5]

Y. Srinivas Ramakrishna ysr at openjdk.org
Thu Sep 18 00:52:35 UTC 2025


On Wed, 17 Sep 2025 00:20:58 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Reuse the same log message from GenShen which details the composition of the live data to be evacuated. In the non-generational modes, all regions are considered young and nothing will be promoted (or old).
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove redundant collection set logging

Changes look good, other than suggested documentation of a few APIs (see specific comment in review).

src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.hpp line 1:

> 1: /*

Either for the accessors (preferred because they are the public APIs for the class) or for the private data members in which those values are tracked, it would be nice to have a one-line sentence describing what the value is and when the value is valid.

I realize this might seem obvious when working in this code, but the documentation is helpful for those not deeply familiar with these fields or trying to use these many months later.

-------------

Marked as reviewed by ysr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27235#pullrequestreview-3236816177
PR Review Comment: https://git.openjdk.org/jdk/pull/27235#discussion_r2357188582


More information about the hotspot-gc-dev mailing list