RFR: 8367473: Shenandoah: Make the detailed evacuation metrics a runtime diagnostic option [v2]
William Kemper
wkemper at openjdk.org
Thu Sep 18 17:36:35 UTC 2025
On Thu, 18 Sep 2025 00:57:39 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> William Kemper has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'jdk/master' into make-evac-tracking-runtime-option
>> - Only print evacuation info when evac tracking is enabled (generational mode fix)
>> - Make detailed evacuation tracking a diagnostic option in product builds
>
> src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp line 399:
>
>> 397: product(bool, ShenandoahEvacTracking, false, DIAGNOSTIC, \
>> 398: "Collect additional metrics about evacuations. Enabling this " \
>> 399: "track how many objects and how many bytes were evacuated, and " \
>
> Nit: track -> tracks?
> Or may be simply say: "Track additional, more detailed metrics related to evacuations by mutators and GC workers." and elide the first sentence" "Collect additional ..."?
I just fixed the typo. The following sentence explains in some detail what will be tracked and how it will be reported.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27238#discussion_r2360453664
More information about the hotspot-gc-dev
mailing list