RFR: 8368104: Parallel: Refactor PSThreadRootsTaskClosure

[Stefan Karlsson]

On Fri, 19 Sep 2025 15:24:05 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Trivial changing the closure input arg to avoid `PSPromotionManager` lookup.
> 
> Test: tier1

src/hotspot/share/gc/parallel/psScavenge.cpp line 273:

> 271:         PSPromotionManager* pm = PSPromotionManager::gc_thread_promotion_manager(worker_id);
> 272:         PSCardTable* card_table = ParallelScavengeHeap::heap()->card_table();
> 273: 

Please restore this blank line.

src/hotspot/share/gc/parallel/psScavenge.cpp line 295:

> 293:     {
> 294:       PSScavengeRootsClosure root_closure(pm);
> 295:       _oop_storage_strong_par_state.oops_do(&root_closure);

The pm variable isn't local to this scope anymore so it would probably be nicer to move the following part out of the scope:

      // Do the real work
      pm->drain_stacks(false);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27393#discussion_r2363901145
PR Review Comment: https://git.openjdk.org/jdk/pull/27393#discussion_r2363900123