RFR: 8368089: G1: G1PeriodicGCTask::should_start_periodic_gc may use uninitialised value if os::loadavg is unsupported [v2]
Guanqiang Han
ghan at openjdk.org
Mon Sep 22 13:23:56 UTC 2025
> Please review this change. Thanks!
>
> **Description:**
>
> Previously the check combined loadavg() failure and threshold comparison in a single condition. When os::loadavg() returned -1, `recent_load` contained an undefined value but was still logged as if it was a real load average, leading to misleading log output.
>
> **Fix:**
>
> This change separates the failure case from the combined check:
> - If os::loadavg() returns -1, log "System loadavg not supported" and skip.
> - Only compare `recent_load` to the threshold when loadavg() succeeds.
>
> **Test:**
>
> GHA
Guanqiang Han has updated the pull request incrementally with one additional commit since the last revision:
Update g1PeriodicGCTask.cpp
Disable the functionality when os::loadavg() is not supported.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/27413/files
- new: https://git.openjdk.org/jdk/pull/27413/files/a490606c..4ff7567c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=27413&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=27413&range=00-01
Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/27413.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27413/head:pull/27413
PR: https://git.openjdk.org/jdk/pull/27413
More information about the hotspot-gc-dev
mailing list