RFR: 8368251: Parallel: Refactor lgrp_id used in MutableNUMASpace [v2]
Thomas Schatzl
tschatzl at openjdk.org
Wed Sep 24 06:12:19 UTC 2025
On Wed, 24 Sep 2025 06:05:37 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Joel Sikström has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Don't set lgrp_id on Windows since we don't support NUMA there
>
> src/hotspot/os/windows/os_windows.cpp line 543:
>
>> 541: }
>> 542: }
>> 543:
>
> I recommend asserting that `UseNUMA` is false here, with a message like `Should set NUMA id here` to not miss this later.
> I prefer trying to formalize code assumptions.
Or just a "must be" :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27424#discussion_r2374519984
More information about the hotspot-gc-dev
mailing list