RFR: 8368251: Parallel: Refactor lgrp_id used in MutableNUMASpace [v2]

Thomas Schatzl tschatzl at openjdk.org
Wed Sep 24 09:39:16 UTC 2025


On Tue, 23 Sep 2025 08:58:19 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:

>> Hello,
>> 
>> There are multiple cases which handle if the locality group (lgrp) id is negative (-1) in Parallel, specifically in MutableNUMASpace. -1 was historically used to indicate that the hardware topology has changed and that the lgrp id needs to be updated. This is no longer the case, since HotSpot doesn't support CPU/NUMA hotplugging, and the last piece of code setting the lgrp id to -1 was removed in [JDK-8301149](https://bugs.openjdk.org/browse/JDK-8301149).
>> 
>> I propose we simplify the code a bit by not handling edge cases where the lgrp id is -1 and removing os::numa_has_group_homing(), which always return false
>> 
>> Testing:
>>  * Running through Oracle's tier 1-4
>>  * Local NUMA testing tier1-4 with `-XX:+UseParallelGC -XX:+UseNUMA`
>
> Joel Sikström has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Don't set lgrp_id on Windows since we don't support NUMA there

Marked as reviewed by tschatzl (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/27424#pullrequestreview-3262042243


More information about the hotspot-gc-dev mailing list