RFR: 8368015: Shenandoah: fix error in computation of average allocation rate [v5]

William Kemper wkemper at openjdk.org
Wed Sep 24 22:14:13 UTC 2025


On Tue, 23 Sep 2025 22:56:01 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> We use bytes_allocated_since_gc_start() to compute allocation rates.  This leaves a blind spot, as our current implementation ignores allocations and the time period between the moment we begin GC and the first time we update the allocation rate following the start of GC.  When this happens, we typically find that the sampled number of allocations is smaller than the allocations that had accumulated by the time we triggered the start of the current GC cycle.
>> 
>> This PR adds tracking for that accounting gap.
>
> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More override declarations to satisfy certain compilers

Thank you for the changes.

-------------

Marked as reviewed by wkemper (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27398#pullrequestreview-3264893414


More information about the hotspot-gc-dev mailing list