RFR: 8351137: ZGC: Improve ZValueStorage alignment support [v3]

Axel Boldt-Christmas aboldtch at openjdk.org
Fri Sep 26 09:22:58 UTC 2025


> ZValueStorage only align the allocations to the alignment defined by the storage but ignores the alignment of the types. Right now all usages of our different storages all have types which have an alignment less than or equal to the alignment set by its storage.
> 
> I wish to improve this so that types with greater alignment than the storage alignment can be used.
> 
> The UB caused by using a type larger than the storage alignment is something I have seen materialise as returning bad address (and crashing) on Windows.
> 
> As we use `utilities/align.hpp` for our alignment utilities we only support power of two alignment, I added extra asserts here because we use the fact that `lcm(x, y) = max(x, y)` if both are powers of two. 
> 
> Testing:
>   * tier 1 through tier 5 Oracle supported platforms
>   * GHA

Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge tag 'jdk-26+17' into JDK-8351137
   
   Added tag jdk-26+17 for changeset 2aafda19
 - Merge remote-tracking branch 'upstream_jdk/master' into JDK-8351137
 - 8351137: ZGC: Improve ZValueStorage alignment support

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/23887/files
  - new: https://git.openjdk.org/jdk/pull/23887/files/ccca8a5d..857249f5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=23887&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23887&range=01-02

  Stats: 565837 lines in 8608 files changed: 383369 ins; 124373 del; 58095 mod
  Patch: https://git.openjdk.org/jdk/pull/23887.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23887/head:pull/23887

PR: https://git.openjdk.org/jdk/pull/23887


More information about the hotspot-gc-dev mailing list