RFR: 8368681: Shenandoah: Add documentation comments for ShenandoahAllocationRate [v2]

Kelvin Nilsen kdnilsen at openjdk.org
Sat Sep 27 23:13:35 UTC 2025


On Thu, 25 Sep 2025 23:46:11 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix several typos
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.hpp line 53:
> 
>> 51:   // Return the newly computed rate if the sample is taken, zero if it is not an appropriate time to add a sample.
>> 52:   // In the case that a new sample is not take, overwrite unaccounted_bytes_allocated with bytes allocated since
>> 53:   // the previous sample was taken (allocated - __last_sample_value).  Otherwise, overwrite unaccounted_byets_allocated
> 
> s/byets/bytes

Thanks.  Fixed.

> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.hpp line 73:
> 
>> 71:  private:
>> 72: 
>> 73:   // Return the instantaneous rate calculated from from (allocated - _last_sample_value) / (time - _last_sample_time).
> 
> s/from from/from

Thanks.  Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27505#discussion_r2384381257
PR Review Comment: https://git.openjdk.org/jdk/pull/27505#discussion_r2384381400


More information about the hotspot-gc-dev mailing list