RFR: 8376761: ARM32: Constant base assert after JDK-8373266

Albert Mingkun Yang ayang at openjdk.org
Wed Feb 4 08:39:47 UTC 2026


On Wed, 4 Feb 2026 08:03:33 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Maybe, but the current fix follows https://github.com/openjdk/jdk/commit/88c8a55a4337a857ac17ffff068f730f67cf5763 style.

Thanks for the link. I skimmed through it and found the following sites of that style:

`disassembler.cpp`: I don't understand why can't all GCs use the same `card_table()->byte_map_base()` path to retrieve `card_table_base`. Is specializing the constant-card-table-base case just for perf purpose? (I tend to think it's written that way because card-table-base was always constant for `CardTableBarrierSet` from the start.)

`jvmciCompilerToVMInit.cpp` probably don't need to use `bs->is_a` -- directly checking `UseXGC` is enough, which is more similar to the scenario here.

Based on that, I am leaned towards not using `bs->is_a` in all those cases; just my 2c.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29528#issuecomment-3846075650


More information about the hotspot-gc-dev mailing list