Integrated: 8377200: Shenandoah: Convert shenandoahSharedVariables and related code to use Atomic<T>

William Kemper wkemper at openjdk.org
Wed Feb 11 09:46:38 UTC 2026


On Thu, 5 Feb 2026 21:18:05 GMT, Ben Taylor <btaylor at openjdk.org> wrote:

> Modernizes ShenandoahSharedVariables code by replacing AtomicAccess methods with Atomic<T> types.
> 
> Tier1 test results on x86_64 linux are the same before and after this change when running with TEST_VM_OPTS=-XX:+UseShenandoahGC.

Looks good, one spot where indentation looks off.

Thank you for the changes.

src/hotspot/share/gc/shenandoah/shenandoahSharedVariables.hpp line 134:

> 132:     ShenandoahSharedValue mask_val = (ShenandoahSharedValue) mask;
> 133:     while (true) {
> 134:         ShenandoahSharedValue ov = value.load_acquire();

Indentation a little off here?

src/hotspot/share/gc/shenandoah/shenandoahSharedVariables.hpp line 186:

> 184:   }
> 185: 
> 186:   volatile ShenandoahSharedValue* addr_of() {

I take it nobody is using this?

-------------

Changes requested by wkemper (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29594#pullrequestreview-3765667166
Marked as reviewed by wkemper (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29594#pullrequestreview-3782352641
PR Review Comment: https://git.openjdk.org/jdk/pull/29594#discussion_r2776513147
PR Review Comment: https://git.openjdk.org/jdk/pull/29594#discussion_r2776514072


More information about the hotspot-gc-dev mailing list