RFR: 8373253: Re-work InjectGCWorkerCreationFailure for future changes [v3]
Thomas Schatzl
tschatzl at openjdk.org
Wed Jan 7 15:35:33 UTC 2026
On Wed, 7 Jan 2026 12:52:25 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
>> This PR slightly changes when we may `InjectGCWorkerCreationFailure`. At the moment we wait until `is_init_completed()`. I am changing this to instead be after `_created_workers > 0`. The reason is that we might in the future, https://bugs.openjdk.org/browse/JDK-8367993, create even more threads "on demand", and if so, we would fail VM creation if we inject worker creation failures after the VM is initiated but before we have created any of the worker threads.
>>
>> This change should not change the current behaviour. But help future improvements.
>>
>> I have tested this on `test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithG1.java`, the only place where this flag is tested to my knowledge.
>
> Leo Korinth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'master' into _8373253
> - Fixup after comment from Ivan.
> - 8373253: Re-work InjectGCWorkerCreationFailure for future changes
Marked as reviewed by tschatzl (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/28719#pullrequestreview-3635454886
More information about the hotspot-gc-dev
mailing list