RFR: 8340470: G1: Adopt PartialArrayState to consolidate marking stack in Full GC [v2]

Thomas Schatzl tschatzl at openjdk.org
Thu Jan 8 13:49:35 UTC 2026


On Thu, 8 Jan 2026 12:58:07 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi,
>> 
>> Please review this change adopting `PartialArrayState` introduced by [JDK-8337709](https://bugs.openjdk.org/browse/JDK-8337709) to consolidate marking queue sets (oop queue set and objArray queue set) into single queue set in G1 Full GC.
>> 
>> Testing: Tier 1-5
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   missing include

Looks good. One typo to fix though...

src/hotspot/share/gc/g1/g1FullGCMarker.cpp line 78:

> 76:     follow_marking_stacks();
> 77:     ScannerTask stolen_task;
> 78:     if(task_queues->steal(_worker_id, stolen_task)) {

Suggestion:

    if (task_queues->steal(_worker_id, stolen_task)) {

src/hotspot/share/gc/g1/g1FullGCMarker.hpp line 72:

> 70:   G1RegionMarkStatsCache _mark_stats_cache;
> 71: 
> 72:   inline bool task_queue_empty();

Potentially add a verb to the name like `is_task_queue_empty()` to make it abundantly clear what this does.

-------------

Changes requested by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29114#pullrequestreview-3639488629
PR Review Comment: https://git.openjdk.org/jdk/pull/29114#discussion_r2672413987
PR Review Comment: https://git.openjdk.org/jdk/pull/29114#discussion_r2672420435


More information about the hotspot-gc-dev mailing list