RFR: 8357471: GenShen: Share collector reserves between young and old [v27]

Kelvin Nilsen kdnilsen at openjdk.org
Thu Jan 8 17:52:41 UTC 2026


On Wed, 7 Jan 2026 22:23:05 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move special handling into ShenandoahYoungHeuristics::choose_collection_set_from_regiondata()
>
> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 165:
> 
>> 163:   }
>> 164: 
>> 165:   assert(heap->is_concurrent_weak_root_in_progress(), "Must be doing weak roots now");
> 
> Was there a reason to remove this `assert`?

May have been an accident.  I'll put it back in and see what happens.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25357#discussion_r2673304717


More information about the hotspot-gc-dev mailing list