RFR: 8357471: GenShen: Share collector reserves between young and old [v25]
Kelvin Nilsen
kdnilsen at openjdk.org
Thu Jan 8 17:55:26 UTC 2026
On Thu, 8 Jan 2026 00:42:47 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix confusing comment
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahOldHeuristics.cpp line 342:
>
>> 340: }
>> 341:
>> 342: bool ShenandoahOldHeuristics::top_off_collection_set(ssize_t &add_regions_to_old) {
>
> Does `add_regions_to_old` really need to be signed? Seems like it will always be non-negative here.
Good point. I'm changing to unsigned.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25357#discussion_r2673318439
More information about the hotspot-gc-dev
mailing list