RFR: 8373253: Re-work InjectGCWorkerCreationFailure for future changes [v4]

[Leo Korinth]

On Mon, 19 Jan 2026 08:39:09 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> This PR slightly changes when we may `InjectGCWorkerCreationFailure`.  At the moment we wait until `is_init_completed()`. I am changing this to instead be after `_created_workers > 0`. The reason is that we might in the future, https://bugs.openjdk.org/browse/JDK-8367993,  create even more threads "on demand", and if so, we would fail VM creation if we inject worker creation failures after the VM is initiated but before we have created any of the worker threads.
>> 
>> This change should not change the current behaviour. But help future improvements.
>> 
>> I have tested this on `test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithG1.java`, the only place where this flag is tested to my knowledge.
>
> Leo Korinth has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - Proposal by Stefan J
>  - wip
>  - Revert "8373253: Re-work InjectGCWorkerCreationFailure for future changes"
>    
>    This reverts commit d45ea8817ab2303b2decd8cbb2cd1bf5280aa181.
>  - Revert "Fixup after comment from Ivan."
>    
>    This reverts commit 2aa8aa4b68027b62a8d4be1b86720fadfa48dda5.

So I reverted all my earlier changes and used Stefan J's suggestion. The "wip" commit includes a temporary version that did not make it from me (using De Morgan rewrite), and you can ignore it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28719#issuecomment-3767160448